FIX: Implemented Throttle Delay of 1 sec for Workflow Socket Messages#899
Closed
tahierhussain wants to merge 2 commits intomainfrom
Closed
FIX: Implemented Throttle Delay of 1 sec for Workflow Socket Messages#899tahierhussain wants to merge 2 commits intomainfrom
tahierhussain wants to merge 2 commits intomainfrom
Conversation
tahierhussain
requested review from
athul-rs,
jagadeeswaran-zipstack and
vishnuszipstack
Contributor
|
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added throttling with a 1-second delay to handle workflow socket messages.
Why
Without throttling, excessive socket messages arriving within milliseconds caused recursive updates, leading to performance issues and unnecessary component re-renders.
How
Used lodash/throttle to buffer incoming workflow socket messages and process them at a controlled interval of 1 second.
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Yes, this PR includes changes to the component that handles socket messages. So, there is a possibility of it breaking existing features.
Database Migrations
NA
Env Config
NA
Relevant Docs
NA
Related Issues or PRs
NA
Dependencies Versions
NA
Notes on Testing
NA
Screenshots
Checklist
I have read and understood the Contribution Guidelines.